Document how to manually create a domain CR #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markxnelson
requested review from
rjeberhard,
tbarnes-us,
rosemarymarano,
bhavaniravichandran,
doxiao and
moreaut
moreaut
reviewed
Jan 15, 2019
kubernetes/samples/scripts/create-weblogic-domain/manually-create-domain/README.md
Show resolved
Hide resolved
| # Update this with the `domainUID` of your domain: | ||
| name: domain1 | ||
| # Update this with the namespace your domain will run in: | ||
| namespace: weblogic |
There was a problem hiding this comment.
'weblogic' probably isn't a good default namespace name - how about 'default' ?
There was a problem hiding this comment.
Yes, and 'default' is the default in the helm chart, correct?
kubernetes/samples/scripts/create-weblogic-domain/manually-create-domain/domain.yaml
Show resolved
Hide resolved
kubernetes/samples/scripts/create-weblogic-domain/manually-create-domain/domain.yaml
Show resolved
Hide resolved
kubernetes/samples/scripts/create-weblogic-domain/manually-create-domain/domain.yaml
Show resolved
Hide resolved
| When it is ready, you can create the domain in your Kubernetes cluster using the command: | ||
|
|
||
| ``` | ||
| kubectl apply -f domain.yaml |
There was a problem hiding this comment.
I think we standardized on using the dollar sign before commands:
$ kubectl apply -f domain.yaml
| Docker image containing your domain and the specific patches that you require, then this approach will probably | ||
| be most suitable for your needs. | ||
|
|
||
| To create the domain custom resource, just make a copy of the sample [domain.yaml](./domain.yaml) provided in |
There was a problem hiding this comment.
just make a copy of the sample domain.yaml provided in this sample, and then -> just make a copy of this sample domain.yaml, and then
doxiao
reviewed
Jan 15, 2019
kubernetes/samples/scripts/create-weblogic-domain/manually-create-domain/domain.yaml
Show resolved
Hide resolved
kubernetes/samples/scripts/create-weblogic-domain/manually-create-domain/domain.yaml
Show resolved
Hide resolved
kubernetes/samples/scripts/create-weblogic-domain/manually-create-domain/domain.yaml
Show resolved
Hide resolved
|
LGTM |
bhavaniravichandran
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.