Prepare for WKO 3.4.6 #3993
Merged
Prepare for WKO 3.4.6 #3993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -57,6 +58,15 @@ draft: false | |||
|
|
|||
| ### Change log | |||
|
|
|||
| #### Operator 3.4.6 | |||
|
|
|||
| * Resolved several issues related to WebLogic Deploy Tooling (WDT) models for Model in Image | |||
There was a problem hiding this comment.
Period at the end of the sentence.
| #### Operator 3.4.6 | ||
|
|
||
| * Resolved several issues related to WebLogic Deploy Tooling (WDT) models for Model in Image | ||
| * Support or provide clearer validation errors for cases where `AdminServerName` is set or missing and where there is or is not a matching entry under `Server`. |
There was a problem hiding this comment.
We generally use past tense in these statements, so:
- Added support or provided...
|
|
||
| * Resolved several issues related to WebLogic Deploy Tooling (WDT) models for Model in Image | ||
| * Support or provide clearer validation errors for cases where `AdminServerName` is set or missing and where there is or is not a matching entry under `Server`. | ||
| * Improve support for dynamic clusters that do not specify `ServerTemplate` or `DynamicClusterSize`. |
| * Resolved several issues related to WebLogic Deploy Tooling (WDT) models for Model in Image | ||
| * Support or provide clearer validation errors for cases where `AdminServerName` is set or missing and where there is or is not a matching entry under `Server`. | ||
| * Improve support for dynamic clusters that do not specify `ServerTemplate` or `DynamicClusterSize`. | ||
| * Provide clearer validation errors for configured clusters that have no member servers defined under `Server`. |
There was a problem hiding this comment.
Minor: The validation error pertains to the dynamic cluster that have no ServerTemplate defined under DynamicServers.
ankedia
reviewed
Feb 16, 2023
| * Support or provide clearer validation errors for cases where `AdminServerName` is set or missing and where there is or is not a matching entry under `Server`. | ||
| * Improve support for dynamic clusters that do not specify `ServerTemplate` or `DynamicClusterSize`. | ||
| * Provide clearer validation errors for configured clusters that have no member servers defined under `Server`. | ||
| * Resolved an issue related to an NPE generated while ensuring container port names are not longer than the Kubernetes enforced maximum of 15 characters. |
There was a problem hiding this comment.
Minor: The issue with container port names was causing StringIndexOutOfBoundsException instead of NPE.
| * Resolved several issues related to WebLogic Deploy Tooling (WDT) models for Model in Image | ||
| * Support or provide clearer validation errors for cases where `AdminServerName` is set or missing and where there is or is not a matching entry under `Server`. | ||
| * Improve support for dynamic clusters that do not specify `ServerTemplate` or `DynamicClusterSize`. | ||
| * Provide clearer validation errors for configured clusters that have no member servers defined under `Server`. |
There was a problem hiding this comment.
Minor: The validation error pertains to the dynamic cluster that have no ServerTemplate defined under DynamicServers.
|
Kudos, SonarCloud Quality Gate passed!
|
rosemarymarano
approved these changes
Feb 17, 2023
| #### Operator 3.4.6 | ||
|
|
||
| * Resolved several issues related to WebLogic Deploy Tooling (WDT) models for Model in Image. | ||
| * Added Support or provided clearer validation errors for cases where `AdminServerName` is set or missing and where there is or is not a matching entry under `Server`. |
| @@ -8,6 +8,7 @@ draft: false | |||
|
|
|||
| | Date | Version | Introduces backward incompatibilities? | Change - See also, [Change log](#change-log). | | |||
| |--------------------|----------|---------------------------------------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | February 17, 2023 | v3.4.6 | no | Resolved several issues related to WDT models for Model in Image, resolved an issue related to an exception while correcting container port names, and updates including the WebLogic Monitoring Exporter. | | |||
There was a problem hiding this comment.
-> updates including the WebLogic Monitoring Exporter
Every time I read this, I have a hard time discerning what you mean, until I read the Change Log. What I would suggest is:
-> updates including the WebLogic Monitoring Exporter version. OR
-> updates including the version of WebLogic Monitoring Exporter.
ankedia
reviewed
Feb 17, 2023
| * Resolved several issues related to WebLogic Deploy Tooling (WDT) models for Model in Image. | ||
| * Added Support or provided clearer validation errors for cases where `AdminServerName` is set or missing and where there is or is not a matching entry under `Server`. | ||
| * Improved support for dynamic clusters that do not specify `ServerTemplate` or `DynamicClusterSize`. | ||
| * Provided clearer validation errors for configured clusters that have no member servers defined under `DynamicServers`. |
There was a problem hiding this comment.
Minor - The clear error message is for dynamic cluster i.e. "Provided clearer validation errors for dynamic clusters".
ankedia
approved these changes
Feb 17, 2023
robertpatrick
pushed a commit
that referenced
this pull request
Apr 12, 2023
* Prepare for WKO 3.4.6
rjeberhard
added a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Apr 14, 2023
* Prepare for WKO 3.4.6
rjeberhard
added a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Apr 14, 2023
* Prepare for WKO 3.4.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.