Disable REST endpoint by default #3958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
sankarpn
reviewed
Feb 15, 2023
| @@ -365,8 +365,7 @@ void testCreateDeleteCreateOperatorButNotDomain() { | |||
|
|
|||
| //check if the operator can still manage domain1 | |||
| int replicaCountDomain1 = 2; | |||
| assertTrue(scaleClusterWithRestApi(domain1Uid, clusterName,replicaCountDomain1 - 1, | |||
| externalRestHttpsPort,opNamespace, opServiceAccount), | |||
| assertTrue(scaleCluster(domain1Uid + "-" + clusterName, domain1Namespace, replicaCountDomain1 - 1), | |||
There was a problem hiding this comment.
Since the REST api is not used to scale cluster this code can be removed.
createRouteForOKD("external-weblogic-operator-svc", opNamespace); setTlsTerminationForRoute("external-weblogic-operator-svc", opNamespace); int externalRestHttpsPort = getServiceNodePort(opNamespace, "external-weblogic-operator-svc"); assertNotEquals(-1, externalRestHttpsPort, "Could not get the Operator external service node port"); logger.info("externalRestHttpsPort {0}", externalRestHttpsPort);
|
Kudos, SonarCloud Quality Gate passed! |
ankedia
approved these changes
Feb 16, 2023
rjeberhard
added a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Apr 14, 2023
* Disable REST endpoint by default
robertpatrick
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Disable REST endpoint by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a draft PR so that I can run integration tests. Presently, I expect this to cause failures in existing integration tests.
Disable the operator REST endpoint by default. It can be enabled with a Helm variable.