OWLS-96896 - Restart Evicted Pods #2979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sary changes from PodWatcher
jshum2479
reviewed
Apr 21, 2022
| @@ -185,6 +185,8 @@ WLSKO-0223=When fluentdSpecification is specified in the domain spec, a secret c | |||
| must be specified in {0} | |||
| WKSKO-0224=Fluentd configmap created. | |||
| WKSKO-0225=Fluentd configmap replaced. | |||
| WLSKO-0226=Pod {0} was evicted due to {1}; validating domain | |||
| WLSKO-0227=Pod {0} was evicted due to {1} but the operator is configured to not restart it. | |||
jshum2479
reviewed
Apr 21, 2022
| @@ -405,7 +406,15 @@ private void processServerPodWatch(V1Pod pod, String watchType) { | |||
| info.setServerPodBeingDeleted(serverName, Boolean.FALSE); | |||
| // fall through | |||
| case MODIFIED: | |||
| info.setServerPodFromEvent(serverName, pod); | |||
| boolean podAlreadyEvicted = info.setServerPodFromEvent(serverName, pod, PodHelper::isEvicted); | |||
| if (PodHelper.isEvicted(pod) && !podAlreadyEvicted) { | |||
There was a problem hiding this comment.
What's the difference between PodHelper.isEvicted() vs podAlreadyEvicted ? When will podAlreadyEvicted be true?
There was a problem hiding this comment.
PodHelper.isEvicted(pod) is true if the new pod from the PodWatch event is evicted.
podAlreadyEvicted is true if the original pod from getSko(serverName).getPod() was already evicted.
should the variable be renamed to avoid confusion? podPreviouslyEvicted?
There was a problem hiding this comment.
Yes, the variable naming is confusing. Thanks.
There was a problem hiding this comment.
renamed to podPreviouslyEvicted. Thanks
|
Kudos, SonarCloud Quality Gate passed! |
jshum2479
approved these changes
Apr 21, 2022
rjeberhard
reviewed
Apr 21, 2022
rjeberhard
approved these changes
Apr 21, 2022
rjeberhard
pushed a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Apr 14, 2023
* restart evicted server pods
robertpatrick
pushed a commit
that referenced
this pull request
Apr 26, 2023
* restart evicted server pods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2794
jenkins https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10119/