Describe service ports with appProtocol #2957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
lennyphan
approved these changes
Apr 15, 2022
rjeberhard
added a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Apr 14, 2023
* Describe service ports with appProtocol
robertpatrick
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Describe service ports with appProtocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8o noticed that the ports for the operator's services were causing warnings for Kiali because they don't follow the Istio guidelines on port-naming and/or protocol designation, as described here: https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection.
I choose not to rename the ports because the port names are references in some of our scripts, e.g.
scalingAction.sh, therefore, I choose the other alternative which is to add theappProtocolfield with the protocol information.We didn't need to change the operator runtime because Services created by the operator are already sensitive to Istio's port naming requirements.