Skip validating domain list ability if operator has already read, created, or updated CRD #2772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have functionality in Main that trails the behavior in CRDHelper and additionally does a list of domains to validate the the custom type is available. Oddly, I could consistently reproduce getting a 404 trying to list domains immediately after creating the CRD. This meant that most customers would see a SEVERE message in the operator's log when the operator was started pointing at a fresh cluster.
Looking at the requirement, we added the domain list as a CRD "presence check" in response to use cases where the operator did not have privilege to read the CRD. We don't actually need this extra check if the operator was able to read, create, or update the CRD.
This PR skips the presence check if the operator was able to read, create, or update the CRD.