Skip to content

OWLS-93960 - NPE fix in PodDisruptionBudgetHelper #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Conversation

ankedia
Copy link
Member

@ankedia ankedia commented Nov 22, 2021

The change to use label selectors when listing the PodDisruptionBudgets to filter out PDBs not created by the operator and PDBs for other domains. Modified the createNonOperatorPodDisruptionBudget method in the DomainProcessorTest to not add cluster-name and domain-uid labels and added a new unit test.

@russgold
Copy link
Member

russgold commented Nov 22, 2021

This is described as an NPE fix. What unit test reproduces the NPE, and how did you fix it?
I added new unit test whenMakeRightExecuted_ignoreNonOperatorPodDisruptionBudgets in DomainProcessorTest which reproduces the NPE. It's fixed by making sure that we don't try to add PDBs that don't have weblogic.clusterName or weblogic.createdByOperator=true label to DomainPrecenseInfo.

@rjeberhard rjeberhard merged commit 5e3d1b4 into main Nov 22, 2021
@ankedia ankedia deleted the owls_93960_npe_fix branch November 23, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants