Skip to content

OWLS-93641 - Fix for MII auxiliary image negative test case failure on OKD #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

ankedia
Copy link
Member

@ankedia ankedia commented Nov 16, 2021

The permission denied error was because of missing "&" when redirecting the standard error to standard output during ls -1 command execution. This didn't fail on other platforms but fails on OKD due to different permissions. Maggie has verified that the fix resolves the issue on OKD and entire MIIAuxiliaryImage test suite is passing with this change on OKD.

Copy link

@tbarnes-us tbarnes-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This makes a lot of sense. That said, I have a small kernel of worry: I could be mistaken but I vaguely recall the '&' was there at one point and now seems. to have been taken out - perhaps by @jshum2479 ? Not sure how to work back through the history?

@ankedia
Copy link
Member Author

ankedia commented Nov 16, 2021

Approved. This makes a lot of sense. That said, I have a small kernel of worry: I could be mistaken but I vaguely recall the '&' was there at one point and now seems. to have been taken out - perhaps by @jshum2479 ? Not sure how to work back through the history?
Thanks. In looking at the git history, it seems '&' was missing in the original pull and I don't think it was taken out.

@rjeberhard rjeberhard merged commit 5c78b8d into main Nov 17, 2021
@rjeberhard
Copy link
Member

I'll cherry pick this commit to release/3.3 just in case.

@ankedia ankedia deleted the owls_93641 branch November 23, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants