OWLS-93783: WLSVERSIONEARLIERTHAN METHOD IS MISSING IN 3.3.3 #2616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doxiao
reviewed
Nov 8, 2021
| from weblogic.management.configuration import LegalHelper | ||
| # WLS Domain versions supported by operator are 12.2.1.3 + patches, 12.2.1.4 | ||
| # and 14.1.1.0 so current version will only be one of these that are listed. | ||
| return LegalHelper.versionEarlierThan("14.1.1.0", version) |
There was a problem hiding this comment.
The code that was removed by PR #2582 checks against 14.1.2.0. Just want to make sure that changing from 14.1.2.0 to 14.1.1.0 here is intentional.
There was a problem hiding this comment.
yes, it turns out from talking to Quang that secure mode will be enabled by default in 14.1.2.0 so had to change it. This is intentional.
rjeberhard
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing wlsVersionEarlierThan method in model filtering for MII and add unit tests to verify isSecureModeEnabled and missing import.