Skip to content

Owls 93071 - Display correct readyReplicas and server state when domain serverStartPolicy switched to NEVER #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2021

Conversation

ankedia
Copy link
Member

@ankedia ankedia commented Oct 18, 2021

The incorrect readyReplicas was because the status update fiber was using a stale DPI cache for the list of ready pods. With this change, the StatusUpdate step that runs periodically makes use of the DPI cached in the DomainProcessorImpl instead of DPI passed when scheduling the domain status updating.

The change also deletes the server pod from DPI when the pod is not found during a list operation and is fully deleted. The server state is displayed as SHUTTING_DOWN when the pod is being deleted and SHUTDOWN after the pod is deleted.

Added unit test to verify the changed behavior. The integration test results are at - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/6762/

@rjeberhard
Copy link
Member

@ankedia, I believe that you told me that this change would not need to be forward ported to main. It seems like this change covers a lot of edge cases. I would want to be sure that none of these edge cases still need to be covered on main.

@ankedia
Copy link
Member Author

ankedia commented Oct 20, 2021

@ankedia, I believe that you told me that this change would not need to be forward ported to main. It seems like this change covers a lot of edge cases. I would want to be sure that none of these edge cases still need to be covered on main.
@rjeberhard - ok, I will run the tests against the main branch to see if same issue exists in main and work on forward porting these changes accordingly. Since lot of domain status functionality has changed in the main branch, I'm not sure if same changes would apply or if they need to be done differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants