Skip to content

OWLS-93072 - Improve domain status failure message to include retry stage and fatal condition #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2021

Conversation

ankedia
Copy link
Member

@ankedia ankedia commented Oct 12, 2021

Changes to domain status message for following conditions -

  1. When retries exceed the max limit, add "introspect failure retry count exceeded error" to the domain status message.
  2. In case of a fatal error, include the fatal status in the domain status message.
  3. For non-fatal retries, indicate the current retry stage i.e. "Introspection failed on try 1 of x".

@tbarnes-us
Copy link

LGTM. Note that this would be easier to review if it was consolidated with Johnny's pull in the same area.

Copy link
Member

@russgold russgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good unit tests and clean up.

@rjeberhard rjeberhard merged commit 1ee25b6 into release/3.3 Oct 14, 2021
@ankedia ankedia deleted the owls_93072 branch October 14, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants