Owls 91563 - Changes to validate the container port names and truncate automatically generated long names #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ankedia
commented
Sep 22, 2021
ankedia
commented
- Validate the container port name lengths for containers provided by the customers.
- Truncate the automatically generated port names (based on NAP names) for WebLogic Server containers.
- Added unit tests for the customer-provided container port validation and truncation of generated port names for WLS containers.
- External Jenkins test run is in progress at - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/6511/
ankedia
requested review from
russgold,
jshum2479,
rjeberhard and
lennyphan
rjeberhard
reviewed
Sep 22, 2021
| int index = containerPortsWithSamePrefix.size() + 1; | ||
| String indexStr = String.valueOf(index); | ||
| // zero fill to the left for single digit index (e.g. 01) | ||
| if (index < 10) { |
There was a problem hiding this comment.
I guess we're hoping that no one ever has 100 channels :)
There was a problem hiding this comment.
All kidding aside... It is extremely unlikely that there will be over 100 channels that are also longer than the maximum name, but we ought to do something here like generate a specific error message.
There was a problem hiding this comment.
:) In addition to 100 channels having longer than the maximum name, these 100 channels also need to have the same first 12 characters. Anyways, I'll look into adding a specific error message.
There was a problem hiding this comment.
Added an error message when more than 100 channels are configured with long names in f9d576a .
… Ryan's PR review comment.
rjeberhard
approved these changes
Sep 23, 2021
alai8
approved these changes
Sep 23, 2021
jshum2479
approved these changes
Sep 23, 2021
ankedia
added a commit
that referenced
this pull request
Sep 23, 2021
…e automatically generated long names (#2542) * Changes to validate the container port names and truncate automatically generated long names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.