-
Notifications
You must be signed in to change notification settings - Fork 218
OWLS-91862 - Documentation for console and WLST access using kubectl port-forward and code changes to handle multiple custom admin channels. #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ss using kubectl port-forward.
General comments:
[ANIL]
|
``` | ||
Forwarding from 127.0.0.1:32015 -> 7001 | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a cleanup notes for ending the forwarding session?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a Terminating the port-forward session
section in 0d1a9a1 .
…sion and minor changes.
…sole and WLST chapters.
…tails and a warning message.
@jshum2479 and @rjeberhard, I've pushed a number of doc updates on top of Anil's updates. If you two are fine with the doc, then it is ready for @rosemarymarano to make a pass. Ryan, I'd especially like you to review all of my version number references (search for 4.0 and 3.3). |
|
||
#### WebLogic HTTP channels | ||
|
||
When providing remote access to HTTP using a load balancer or similar, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"or similar" is confusing here. I know that we mean something like an Ingress gateway, but it's not obvious here. It might be worth spelling it out a bit more such as "load balancer, Ingress gateway, or similar technology,"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
is preferred over a default port because a default port supports | ||
multiple protocols. | ||
|
||
Do not enable tunneling on an HTTP channel unless you specifically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the new security validations complains if tunneling is simply enabled. Given that, we probably should more clearly recommend against using tunneling unless the port is more protected on the network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
||
### Overview | ||
|
||
Beginning with WebLogic Kubernetes Operator version 3.3.2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but we should ask Rosemary to help us wordsmith this. There probably is some simpler way to express this. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rosemarymarano Once the ball is in your court, please see ^^^.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbarnes-us @rjeberhard Sure. "...help us wordsmith this. There probably is some simpler way to express this.
One question: to what are you referring as "this," the Overview section or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that the wording was fine.
@rjeberhard, @jshum2479, and @lennyphan - Can you please re-review my changes to handle multiple custom admin channels in 82672c1 ? Thanks in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any unit tests for adding multiple internal admin channels?
[ANIL] I have added unit tests for multiple internal admin channels and when admin port is enabled in 0b9d8b8 . Please let me know if I missed something.
…els and minor change in logic to determine admin port enabled for MII domain.
…port-forward and code changes to handle multiple custom admin channels. (#2520) * Support kubectl port-forward pattern Co-authored-by: Tom Barnes <tom.barnes@oracle.com> Co-authored-by: Rosemary Marano <rosemary.marano@oracle.com>
…nChannelPortForwardingEnabled to false. (#2532) * Owls 91273 - Create network access points for kubectl port-forward and console access (#2507) * Create network access points for kubectl port-forward and console access * OWLS-91862 - Documentation for console and WLST access using kubectl port-forward and code changes to handle multiple custom admin channels. (#2520) * Support kubectl port-forward pattern Co-authored-by: Tom Barnes <tom.barnes@oracle.com> Co-authored-by: Rosemary Marano <rosemary.marano@oracle.com> * Change adminChannelPortForwardingEnabled default to false. * Change the default ADMIN_CHANNEL_PORT_FORWARDING_ENABLED env variable value to false. * Enabled port forwarding for unit tests. Co-authored-by: Tom Barnes <tom.barnes@oracle.com> Co-authored-by: Rosemary Marano <rosemary.marano@oracle.com>
The documentation for console and WLST access using kubectl port-forward and changes to handle multiple custom admin channel use-case. Added unit tests for the admin port enabled and multiple custom admin channel use-case.