Owls 91266 - Changes to generate CoherenceMemberConfig.UnicastListenAddress for Istio #2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennyphan
reviewed
Aug 11, 2021
| ret = None | ||
| return ret | ||
|
|
||
| def customizeCoherenceMemberConfig(self, listen_address): |
There was a problem hiding this comment.
Will it always be an 'add' action or is it possible that a unicast-listen-address already exists? That is, do we need to handle a replace of the 'replace' action scenario?
There was a problem hiding this comment.
Sorry, I was confused with the mbean name in my earlier comment, please disregard as we discussed earlier. We do need to use replace if it is already there for sitconfig.
… permutations and combinations of config.
rjeberhard
approved these changes
Aug 13, 2021
jshum2479
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to generate CoherenceMemberConfig.UnicastListenAddress for Istio. These include changes to the model WDT filter file for the MII domain and situational config generator for DII and domain-on-pv domains.
Jenkins results - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5908/