Skip to content

Update dependencies including to the Kubernetes Java Client 13 #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 19, 2021

Conversation

rjeberhard
Copy link
Member

Updated dependencies and plugins to latest versions.

Notes:

  • The latest version of Checkstyle had a non backward-compatible change to a property name
  • Used "--add-opens java.base/java.time=ALL-UNNAMED" in place of "--illegal-access=permit" because the later is deprecated and the former is more specific -- the issue you would see without either of these options is that the serialization libraries could not access the fields of OffsetDateTime, which is in the java.time module.
  • The CRDHelper has a utility method to output (serialize) the schema as YAML. This needed some code that I found in the Kubernetes client to properly wrap the constructors so that it would work with the SnakeYAML library.

Copy link
Member

@lennyphan lennyphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit fb897e5 into main Jul 19, 2021
@rjeberhard rjeberhard deleted the apollo-13 branch January 31, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants