OWLS-90614 - Handle ApiException with 409 code returned from the replaceEvent API call #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring replace event and other API calls.
doxiao
reviewed
Jul 7, 2021
| @@ -66,7 +67,12 @@ public static boolean isUnrecoverable(ApiException e) { | |||
|
|
|||
| public static boolean isNotFound(ApiException e) { | |||
| int code = e.getCode(); | |||
| return code == 404 || code == 410; | |||
| return code == 404 || code == 410 || isStorageError(code, e); | |||
There was a problem hiding this comment.
Although we want this specific 409 error to be handled the same as resource not found cases, it is probably cleaner if we introduced a new method, such as hasConflict, for this condition.
ankedia
changed the title
rjeberhard
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to handle ApiException with 409 status code in the replaceEvent async API call seen in the GBU large cluster environment. The code will treat this exception similar to the "404 - Not Found" error so that a new event can be created.