Skip to content

Support clusterService.sessionAffinity #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2021
Merged

Conversation

rjeberhard
Copy link
Member

A customer asked for us to support the sessionAffinity field for the per-cluster Service. While we've recommended setting session affinity at the ingress controller or load balancer, there is nothing inappropriate about a customer wanting to expose the per-cluster service and doing session affinity at this level.

While we've had the cluster.clusterService field for a long time, this is the first time that it has fields that aren't present under the serverService field, so the implementation is introducing a ClusterService class for the first time.

Copy link
Member

@jshum2479 jshum2479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lennyphan lennyphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit c026181 into main May 27, 2021
@rjeberhard rjeberhard deleted the session-improvements branch January 31, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants