Recreate OWLS-86115 work #2344
Merged
Recreate OWLS-86115 work #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarnes-us
reviewed
Apr 27, 2021
|
General comment: I think this change will likely lift a restriction or two that we document in the user guide 'model updates' chapter. We (@jshum2479 @lennyphan and I) should meet to discuss updating the chapter, and whether we should test first. |
|
Successful run of all integration tests on this branch: https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4895/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what happened with GitHub, but when I tried to change the base for @lennyphan's work GitHub created a PR with hundreds of changes. This PR is recreated with just his deltas, but targeted to the main branch. (Original pull: #2285).
In this PR:
For Domain home source type MII, configuration overrides are now generated using WDT model filter. The model filter implementation follows the same logic for generating situational configuration in introspectDomain.py's SitConfigGenerator. Domain home source types Domain-on-PV and Domain-in-Image will continue to use situational configuration overrides.
Added ability to run python based unit tests for model filter implementation.