Cache secret for a configurable time period and reset on auth/authz failure #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where are the tests for this new functionality? I would have expected something which tried the read the secret, and tried again both within and after the timeout, seeing a cached value returned in the first case and a new read from k8s in the latter case. |
|
@russgold, I found that whenAuthorizedToReadHealthAndThenWait_verifySecretCleared was sufficient. This tests that the clearing behavior worked. The earlier tests then validate that the read will happen when the cache is empty. |
russgold
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an observed increase in the operator's network utilization by not reading the webLogicCredentialsSecret every time that it is necessary and, instead, caching the value for a configurable time period. Additionally, the secret is cleared (and then reread on the next iteration) following an auth or authz failure.