Anil: remove stranded dpi's that are no longer present in recheck domain list #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankedia
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
It looks good to me (just one minor comment). I'm not sure if we need any checks to guard against the null dpi (after stranded dpi has been removed) in the suspended (waiting) fiber after it wakes up. It's possible that this change takes care of that and I missed it.
| if ((liveInfo.getDomain() != null) && (!isNewDomain(cachedInfo)) | ||
| && (liveInfo.getDomain().getMetadata().getCreationTimestamp() | ||
| .isAfter(cachedInfo.getDomain().getMetadata().getCreationTimestamp()))) { | ||
| if (liveInfo.getDomain() != null |
There was a problem hiding this comment.
This check is probably not needed now since the getCreationTimestamp() method uses Optional.ofNullable.
There was a problem hiding this comment.
I'm going to merge in to your original branch and then I'll see if we can remove that check. (I've not looked at what isNewDomain does)
rjeberhard
added a commit
that referenced
this pull request
Apr 15, 2021
…luster when watch events are not delivered. (#2305) * OWLS-88571 - Potential fix for GBU CNE issue to start a new fiber for a recreated domain when previous fiber is stuck. * Change for the ProtocolException and NPE issue to discard the API client instance and create a new one. * Change to check if the creationTimestamp of the live domain is newer compared to the cached domain creation timestamp. * remove stranded dpi's that are no longer present in recheck domain list (#2314) * Clean-up stranded domain presence info when watches aren't occurring Co-authored-by: Ryan Eberhard <ryan.eberhard@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anil, I'm giving you a look at this first...
While working on this, I was reminded that the original "stranded" domain use case was where a customer had stopped the operator and then deleted a domain resource. When the operator would later restart, there would be pods, services and perhaps other resources left over, but no domain resource. This is why the dpi would have some resources but no domain.
We are now dealing with a different type of stranded domain -- where the operator has been running the whole time but where the watch events are not firing. In this case, there will still be a cached dpi that has the domain even as a recheck listing of domains will not include that domain. Therefore, we need to treat as deleted any cached domain that isn't found in the recheck list.