Add logging max size and count for rotation #2229
Conversation
| @@ -53,6 +53,10 @@ spec: | |||
| value: "false" | |||
| - name: "JAVA_LOGGING_LEVEL" | |||
| value: {{ .javaLoggingLevel | quote }} | |||
| - name: "JAVA_LOGGING_MAXSIZE" | |||
| value: {{ .javaLoggingFileSizeLimit | default 1000000 | quote }} | |||
There was a problem hiding this comment.
Should we make the default 10MB to match with Kubernetes default (based on this - https://kubernetes.io/docs/concepts/cluster-administration/logging/#logging-at-the-node-level)?
There was a problem hiding this comment.
For Kubernetes, you get by default the last 10 MB of the pod output. Here, we have seven files each of 1 MB. I could match the Kubernetes behavior by changing the number of files from 7 to 10.
There was a problem hiding this comment.
I don't really feel strongly about these defaults, so I'm happy to adjust to the group consensus.
There was a problem hiding this comment.
Ok, I feel going from no max size to 1MB might be a big change for customers. I vote for 10MB as that might cover the majority of use-cases without a need for log rotation.
There was a problem hiding this comment.
Assuming we need 10,000 domains at 50K each at the default INFO level (since a simple relatively inactive domain yields a "few k" of log data at the INFO level), gives us 500 MB. So 10MB X 7 'feels' a little too small too me.
There was a problem hiding this comment.
Unless 1,000 domains is the target? In which case 10MB X 7 looks about right to me...
This comment has been minimized.
This comment has been minimized.
Resolves issue #2220.
I took a hand wave at the appropriate defaults and selected max file size of 1 MB and 7 total files in the rotation.