OWLS-87175 - Allow make right flow to continue when live data from the list older than cached data #2196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flow when cached info is newer than the live info.
…the list is older than the cached data.
rjeberhard
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OWLS-87175 - Allow the make-right flow to continue when live info from the list is older than the cached info for etcd restore case. For etcd restore use-case, cached data can be newer than the live data since etcd snapshot might have been taken at some time in the past. Based on discussion with Ryan, the possibility of cached data being newer than live data is very rare in the normal scenario. This change along with a fix for OWLS-87553 (periodic backstop check in the WaitForReady step) seem to resolve the issue in 32401992 in both Fermin's and my local env.
Integration tests results are at - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4069/ and manual tests in my env seem to work fine.