Skip to content

OWLS-86630 - scalingAction.sh needs adjustment in finding latest API version #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

alai8
Copy link
Member

@alai8 alai8 commented Jan 6, 2021

Update get_domain_api_version in scalingAction.sh to use kubernetes /apis instead of /apis/apiextensions.k8s.io/v1beta1/customresourcedefinites to find the API version for the operator.

Also fixes a missing colon in python script generated for get_min_replicas, and removing it afterwards.

Example of /apis result returned from kubernetes:

{
  "kind": "APIGroupList",
  "apiVersion": "v1",
  "groups": [
    {
     ...
    },
    ...
    {
      "name": "weblogic.oracle",
      "versions": [
        {
          "groupVersion": "weblogic.oracle/v8",
          "version": "v8"
        },
        {
          "groupVersion": "weblogic.oracle/v7",
          "version": "v7"
        }
      ],
      "preferredVersion": {
        "groupVersion": "weblogic.oracle/v8",
        "version": "v8"
      }
    }
  ]
}

get_domain_api_version would return v8 from preferredVersion.version of the group with name weblogic.oracle.

Jenkins result: https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/3532/testReport/

@alai8 alai8 requested review from rjeberhard and lennyphan January 6, 2021 18:09
Copy link
Member

@lennyphan lennyphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit d7305e9 into develop Jan 6, 2021
@alai8 alai8 deleted the owls86630 branch January 7, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants