This repository was archived by the owner on May 28, 2021. It is now read-only.
Keep mysql readonly after exit group unintentionally #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alantang888
changed the title
alantang888
changed the title
prydie
approved these changes
Mar 19, 2019
|
Oh! the signed-off used another email address. Should I need to modify it? |
Since mysql version >= 8.0.12, <= 8.0.15 changed default behavior to `ABORT_SERVER`. Which will shutdown the server after exit group unintentionally. It should better change server to `READ_ONLY` instead of exit. Future version MySQL also change this behavior back to `READ_ONLY` https://dev.mysql.com/doc/refman/8.0/en/group-replication-options.html#sysvar_group_replication_exit_state_action Signed-off-by: Alan Tang <alantang888@gmail.com>
|
If you wouldn't mind, thanks! |
alantang888
force-pushed
the
set_group-replication-exit-state-action_to_readonly
branch
from
8bd10fe to
293bad9
Compare
|
Ok, modified. Thanks a lot. |
|
E2E tests seem to be failing with: |
|
oh... upgrade test. I need to take care of version before 8.0.12... |
Signed-off-by: Alan Tang <alantang888@gmail.com>
alantang888
force-pushed
the
set_group-replication-exit-state-action_to_readonly
branch
from
0b8208e to
7377f35
Compare
Not realized there already have semver can use before. Signed-off-by: Alan Tang <alantang888@gmail.com>
alantang888
force-pushed
the
set_group-replication-exit-state-action_to_readonly
branch
from
7377f35 to
9d02772
Compare
|
Sorry, I think i didn't test it well before PR... |
Because MySQL check variable before load group replication plugin Signed-off-by: Alan Tang <alantang888@gmail.com>
|
This time I don't know why the upgrade test is failed... |
prydie
approved these changes
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MySQL version >= 8.0.12, <= 8.0.15 changed
group-replication-exit-state-actiondefault behavior toABORT_SERVER. Which will shutdown the server after exit group unintentionally. It should better change server toREAD_ONLYinstead of exit.Future version MySQL also change this behavior back to
READ_ONLYhttps://dev.mysql.com/doc/refman/8.0/en/group-replication-options.html#sysvar_group_replication_exit_state_action
Signed-off-by: Alan Tang alantang888@gmail.com