This repository was archived by the owner on May 28, 2021. It is now read-only.
Add support for defining Tolerations in the ClusterSpec #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kashif Saadat <kashifsaadat@gmail.com>
|
Similar to PR #218, the review comments will still apply here also. |
prydie
reviewed
Sep 18, 2018
| @@ -66,6 +66,9 @@ type ClusterSpec struct { | |||
| SSLSecret *corev1.LocalObjectReference `json:"sslSecret,omitempty"` | |||
| // SecurityContext holds pod-level security attributes and common container settings. | |||
| SecurityContext *corev1.PodSecurityContext `json:"securityContext,omitempty"` | |||
| // Tolerations allows specifying a list of tolerations for controlling which | |||
| // set of nodes a pod can be scheduled on | |||
There was a problem hiding this comment.
nit (not worth blocking merge): s/nodes/Nodes/ s/pod/Pod/ and a full-stop.
There was a problem hiding this comment.
Ah sorry! I'll fix it up in a follow-up PR.
prydie
approved these changes
Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #214
Support adding tolerations to the Cluster Spec, for example: