This repository was archived by the owner on May 28, 2021. It is now read-only.
fix backups to disk #209
Merged
fix backups to disk #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydie
added
needs-approval
oracle-cla: no
|
Awesome, thanks @Simon-Li! Changes LGTM 👍 Would you mind rebasing your PR into a singe signed-off commit? Additionally, if you haven't already signed to Oracle Contributor Agreement can you please do so. @owainlewis Can we get the CI hooked up for third-party PRs and trigger a run for this prior to merging? |
prydie
approved these changes
Aug 20, 2018
Signed-off-by: SimonLi <simon.jiyou@gmail.com>
Simon-Li
force-pushed
the
fix-backups-to-disk
branch
from
0a17264 to
8e97239
Compare
|
Rebased and the OCA was submitted, thanks @prydie |
|
Thanks @Simon-Li we are just waiting for an approval on OCA and then we'll get this merged. |
|
I spoke to soon - they've got it! |
prydie
added
oracle-cla: yes
|
Thanks for your contribution @Simon-Li! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is for #147