This repository was archived by the owner on May 28, 2021. It is now read-only.
Remove extra injected environment variables. #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
In my setup, in certain circumstances I need to use the mysql-agent standalone, that is without relying on the operator.
This means that I have to manually create the manifests for the MySQL StatefulSet and Service, so it's in my best interest to keep those as clean as possible.
While doing the translation, I noticed that there seem to be a few environment variables that are injected into the containers but are not used. In particular:
MYSQL_CLUSTER_SERVICE_NAME
is injected but I can't find in the whole history of the project a revision in which it was ever used.MYSQL_CLUSTER_NAME
,POD_NAMESPACE
,REPLICATION_GROUP_SEEDS
,MYSQL_CLUSTER_MULTI_MASTER
are injected into the mysql container, but I can't find a reason for doing so since that's the standard mysql container which doesn't understand those variables, and it's the agent container that needs to consume them.Were they left there in order to be used by a human operator to have better introspection into the components, or are they just a relic from the past? In my tests, everything works fine without injecting them (in my redacted manifests), but please keep in mind I haven't tested the backup/restore logic.
Thanks