Skip to content
This repository was archived by the owner on May 28, 2021. It is now read-only.

Fix mysql-agent InvalidImageName #141

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Conversation

prydie
Copy link

@prydie prydie commented Jun 14, 2018

#128 borked the helm chart without us noticing because e2e tests were failing anyway due to the API changes branch.

  Warning  InspectFailed          4m (x186 over 44m)   kubelet, k8s-worker-ad2-0.k8sworkerad2.k8sbmcs.oraclevcn.com  Failed to apply default image tag "iad.ocir.io/oracle/mysql-agent:6f1a359354f18ec33406ba62e8915863da884f01:6f1a359354f18ec33406ba62e8915863da884f01": couldn't parse image reference "iad.ocir.io/oracle/mysql-agent:6f1a359354f18ec33406ba62e8915863da884f01:6f1a359354f18ec33406ba62e8915863da884f01": invalid reference format

--mysql-agent-image should not contain a version.
@prydie prydie added the bug label Jun 14, 2018
@prydie prydie requested a review from simonlord June 14, 2018 10:56
Copy link

@simonlord simonlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @prydie 👍 Totally my bad. How did #128 get merged though? Surely the e2e would have failed?

@prydie
Copy link
Author

prydie commented Jun 14, 2018

I merged despite the failure because the API changes were breaking the pipeline so also my bad!

@prydie prydie merged commit fa0749f into master Jun 14, 2018
@prydie prydie deleted the ap/fix-broken-mysql-agent-image branch June 14, 2018 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants