Fixes for LSP #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you believe this is an error, please contact graal-dev@openjdk.java.net. |
We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address daniel -(dot)- stolpe -(at)- gmx -(dot)- de. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
|
OCA signed and sent on 20th April to oracle-ca_us -(at)- oracle -(dot)- com |
|
|
Hi Daniel, Thanks a lot for your contribution! We appreciate your feedback and help. Your changes have been merged internally and will be available in one of the next release builds. Stay tuned :)! Cheers, |
graalvmbot
pushed a commit
that referenced
this pull request
May 18, 2022
…sions Merge in ~PETR.PISL_ORACLE.COM/pythonjavapegparser from tim/collections to master * commit '559c23701235992dc30625f94abaf63d5c60408d': add yield small modification to readme add pass, break, continue remove SpecialLiteralSSTNode, we had SimpleSSTNode already update README parse remaining atoms get dict and set comprehensions to work make list comprehension work make loops that collect objects match the type better fix: expect needs to use getAndInitializeToken add more golden files fix newlines in print visitor add dict parsing minor fix for the grammar generator add tuples, clean up generated code some more use generics for insertInFront and appendToEnd actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes findMetaObject(), findTopScopes(), syntax error's source location and off-by-one-errors in SourceSections