Skip to content

Feature/mpdo 1015 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Conversation

karankap
Copy link
Contributor

@karankap karankap commented Sep 8, 2022

Signed-off-by: Karan Kapoor karan.kapoor@oracle.com

Copy link

@Djelibeybi Djelibeybi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions are not required changes, but would improve the formatting and accessibility of the README.md file.

@Djelibeybi
Copy link

It's good practice to specify some type of syntax highlighting for all fenced code blocks. If there is no specific syntax highlighting style for a particular block, just use plain, i.e.

```plain
text goes here
```

Anything that should be run on the command-line should use shell, i.e.

```shell
curl -O http://host/endpoint
```

If you want to show the output from a command, then prefix the command with a $, i.e.

```shell
$ curl -I https://oracle.com
HTTP/1.1 301 Moved Permanently
Date: Tue, 13 Sep 2022 21:58:32 GMT
Content-Type: text/html
Content-Length: 175
Connection: keep-alive
Location: https://www.oracle.com/
```

@karankap
Copy link
Contributor Author

It's good practice to specify some type of syntax highlighting for all fenced code blocks. If there is no specific syntax highlighting style for a particular block, just use plain, i.e.

```plain
text goes here

Anything that should be run on the command-line should use `shell`, i.e.

curl -O http://host/endpoint

If you want to show the output from a command, then prefix the command with a `$`, i.e.

$ curl -I https://oracle.com
HTTP/1.1 301 Moved Permanently
Date: Tue, 13 Sep 2022 21:58:32 GMT
Content-Type: text/html
Content-Length: 175
Connection: keep-alive
Location: https://www.oracle.com/

@Djelibeybi - could you please approve and merge this PR, if everything looks good to you?

@Djelibeybi
Copy link

Unfortunately, I can't approve or merge anything in this repo. I only reviewed it because I knew about it and thought the feedback might be useful.

@karankap
Copy link
Contributor Author

karankap commented Oct 4, 2022

Unfortunately, I can't approve or merge anything in this repo. I only reviewed it because I knew about it and thought the feedback might be useful.

@Djelibeybi - could you pls let me know who can help in approving this PR? It's been pending for a long time now.

@Djelibeybi
Copy link

@karankap I have no elevated access to any of the repos in this organisation, so I can't see any more than you can.

@Govinnd Govinnd merged commit a021aa7 into oracle-samples:master Oct 7, 2022
@karankap karankap deleted the feature/MPDO-1015 branch November 1, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants