JCS-14392 - Issue with volume attachments on scale-out #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make the keys of the maps of compute and volumes resources to have 2 digits at the end, to conserve the iteration order, which is lexicographical, to prevent volume attachments from being reassigned to other instances because of the iteration order in the list of compute instances
- Update copyright header
telake
approved these changes
Mar 22, 2024
| @@ -18,7 +18,7 @@ module "middleware-volume" { | |||
|
|
|||
| module "data-volume" { | |||
| source = "../volume" | |||
| bv_params = { for x in range(var.num_vm_instances) : "${var.resource_name_prefix}-data-block-${x}" => { | |||
| bv_params = { for x in range(var.num_vm_instances) : "${var.resource_name_prefix}-data-block-${format("%02d", x)}" => { | |||
| ad = var.use_regional_subnet ? local.ad_names[(x + local.admin_ad_index) % length(local.ad_names)] : var.availability_domain | |||
| compartment_id = var.compartment_id | |||
| display_name = "${var.resource_name_prefix}-data-block-${x}" | |||
There was a problem hiding this comment.
The change looks good to me.
nitpick:
I noticed you chose to keep the display name single digit (for example - display name is "-1" for data-block "-01"). This is not a functional problem.
There was a problem hiding this comment.
Good observation. It was made on purpose, I wanted to make the least possible changes. There might be code that checks the server names, VM display names, etc. I am not sure and I do not want to break such code, if any
The key of the maps used to create the resource collections are not used in other code that is not terraform, that I am sure. That
HarshadVilekar
approved these changes
Mar 22, 2024
skommala
pushed a commit
that referenced
this pull request
Mar 23, 2024
- Make the keys of the maps of compute and volumes resources to have 2 digits at the end, to conserve the iteration order, which is lexicographical, to prevent volume attachments from being reassigned to other instances because of the iteration order in the list of compute instances Tests: - Created a non-JRF stack with new VCN, and two nodes - Scaled up the stack to 4 nodes, verified the apply job completed successfully and that all servers were added. - Scaled up the stack to 10 nodes, and verified the same points above - Scaled up the stack to 11 nodes, and made the same verifications above, and verified that the existing block volume attachments and block volumes where not affected - Scaled up the stack to 20 nodes, and made the same verifications above - Scaled up the stack to 30 nodes, and made the same verifications above - Scaled down the stack to 10 nodes. Verified that only the artifacts 29 to 10 are deleted, and the rest of the servers are still running (cherry picked from commit 2cfb830)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: