JCS-14046 Support VM.Standard.E5.Flex shape, but not as default shape. #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing using E5.Flex shape (requires OL8.8 image): - 14.1.1.0 JDK11 with IDCS. idcs-sample-app logged into. - 12.2.1.4 JRF on ATP with IDCS (2 OCPU count). idcs-sample-app logged into. - 14.1.1.0 JDK8 with IDCS validated cloning. Testing max cpu utilization (E5.Flex allows 94 ocpu max): - Using same logic changes in this MR built stack with: -- max OCPUs for Flex5 to 1 -- max OCPUs for Flex4 to 2 -- Set 2 OCPUs for Flex 5 and ran tf plan. Confirmed validation error fired. -- Set 3 OCPUs for Flex 4 and ran tf plan. Confirmed validation error fired. This shows no regression in the logic changes.
HarshadVilekar
approved these changes
Oct 30, 2023
skommala
approved these changes
Oct 30, 2023
|
Changes look fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCS-14046 Support VM.Standard.E5.Flex shape, but not as default shape.
Testing using E5.Flex shape (requires OL8.8 image):
Testing max cpu utilization (E5.Flex allows 94 ocpu max):
-- max OCPUs for Flex5 to 1
-- max OCPUs for Flex4 to 2
-- Set 2 OCPUs for Flex 5 and ran tf plan. Confirmed validation error fired.
-- Set 3 OCPUs for Flex 4 and ran tf plan. Confirmed validation error fired. This shows no regression in the logic changes.