Skip to content

Fix bug Certificate on LB is reset in scaling operation #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

skommala
Copy link
Member

@skommala skommala commented Aug 22, 2023

Fixed bug Certificate on LB is reset in scaling operation.
Test

Create a single VM instance with load balancer.
Create a new certificate to the load balancer.
    Note that you can generate a keypair from any OCI compute instance with 'openssl req -new -sha256 -newkey rsa:2048 -nodes -keyout testssl.key -x509 -days 365 -out testssl.crt'
    Note that you'll need to add both the certificate and private key pems that are generated to the certificate.
Associate the certificate you added to the listener for the load balancer.
Delete the demo certificate that was generated by the Stack from the load balancer.
Edit the stack and add a node.
Make sure that new certificate is assigned to the listener.
Demo certificate will be recreated but not assigned to any.

The certificate created and added by a customer is not reset, but will still restore the cert created by terraform if it is deleted.

Copy link
Member

@telake telake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. However, when merging be sure to include in the merge comment that this only ensures that any certificate added by a customer is not reset, but will still restore the cert created by terraform if it is deleted.

@skommala skommala merged commit 46c4c45 into development Aug 24, 2023
@skommala skommala deleted the topic_sk_jcs_13953 branch August 24, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants