Skip to content

fix: remove unecessary @Dependent annotation #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022
Merged

fix: remove unecessary @Dependent annotation #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions samples/quarkus/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@
<artifactId>admission-controller-framework-core</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-kubernetes-client</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-junit5</artifactId>
Expand Down
2 changes: 0 additions & 2 deletions ...javaoperatorsdk/webhook/admission/sample/quarkus/admission/AdmissionControllerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import java.util.HashMap;
import java.util.concurrent.CompletableFuture;

import javax.enterprise.context.Dependent;
import javax.inject.Named;
import javax.inject.Singleton;

Expand All @@ -15,7 +14,6 @@
import io.javaoperatorsdk.webhook.admission.mutation.Mutator;
import io.javaoperatorsdk.webhook.admission.validation.Validator;

@Dependent
public class AdmissionControllerConfig {

public static final String APP_NAME_LABEL_KEY = "app.kubernetes.io/name";
Expand Down
2 changes: 0 additions & 2 deletions ...vaoperatorsdk/webhook/admission/sample/quarkus/conversion/ConversionControllerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.javaoperatorsdk.webhook.admission.sample.quarkus.conversion;

import javax.enterprise.context.Dependent;
import javax.inject.Singleton;

import io.javaoperatorsdk.webhook.conversion.AsyncConversionController;
Expand All @@ -10,7 +9,6 @@
import io.javaoperatorsdk.webhook.sample.commons.mapper.V1Mapper;
import io.javaoperatorsdk.webhook.sample.commons.mapper.V2Mapper;

@Dependent
public class ConversionControllerConfig {


Expand Down