Skip to content

feat: config option to not exit when stops leading #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat: config option to not exit when stops leading #2500

merged 2 commits into from
Aug 19, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Aug 18, 2024

No description provided.

@csviri
feat: config option to not exit when stops leading
bd2666f 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri self-assigned this Aug 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2024
@csviri csviri linked an issue Aug 18, 2024 that may be closed by this pull request
LeaderElectionManager invokes System.exit() directly #2496
Closed
adriansuarez
adriansuarez approved these changes Aug 18, 2024
View reviewed changes
Copy link

@adriansuarez adriansuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csviri Looks good. Thanks for jumping on this.

This enables my use case described in #2496.

@csviri csviri marked this pull request as ready for review August 18, 2024 16:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2024
@openshift-ci openshift-ci bot requested review from adam-sandor and andreaTP August 18, 2024 16:12
@csviri @metacosm
Update operator-framework-core/src/main/java/io/javaoperatorsdk/opera…
463ad9d 
…tor/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
@csviri csviri merged commit 2d408b3 into next Aug 19, 2024
19 of 20 checks passed
@csviri csviri deleted the le-stop-improvements branch August 19, 2024 06:58
metacosm added a commit that referenced this pull request Aug 29, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
8832996 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
@csviri csviri mentioned this pull request Sep 17, 2024
Merged
csviri added a commit that referenced this pull request Sep 20, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
8432449 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm added a commit that referenced this pull request Oct 10, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
b0a60ea 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm added a commit that referenced this pull request Nov 5, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
2faadb5 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm added a commit that referenced this pull request Nov 6, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
88cdb2e 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
csviri added a commit that referenced this pull request Nov 13, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
d6a67ab 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm added a commit that referenced this pull request Nov 19, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
b5f039d 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm added a commit that referenced this pull request Nov 20, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
9b3fdef 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm added a commit that referenced this pull request Nov 27, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
b91f520 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
This was referenced Dec 3, 2024
Merged
Closed
csviri added a commit that referenced this pull request Dec 6, 2024
@csviri @metacosm
feat: config option to not exit when stops leading (#2500)
664d335 
* feat: config option to not exit when stops leading

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adriansuarez adriansuarez adriansuarez approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LeaderElectionManager invokes System.exit() directly
3 participants
@csviri @metacosm @adriansuarez