Skip to content

refactor: clean up ResourceConfiguration & rename to Informable #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 19, 2024

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Aug 9, 2024

Signed-off-by: Chris Laprun claprun@redhat.com

@metacosm metacosm self-assigned this Aug 9, 2024
@metacosm metacosm requested a review from csviri August 9, 2024 14:01
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2024
csviri and others added 10 commits August 16, 2024 14:24
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
… based on type (#2483)

* refactor: integration tests moved to feature packages and sub packages pased on type

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* fix resource paths

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* fixes

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* link and test fixes

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* format

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* wip

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* old service

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* test fix

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* refactor: remove unneeded classes

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: typo in package name

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm force-pushed the remove-resourceconfig branch from 8c4fd8d to 724008a Compare August 16, 2024 12:44
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2024
@metacosm metacosm marked this pull request as ready for review August 16, 2024 12:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2024
@openshift-ci openshift-ci bot requested review from adam-sandor and andreaTP August 16, 2024 12:47
@metacosm metacosm changed the title refactor: move functionality out of ResourceConfiguration refactor: clean up ResourceConfiguration & rename to Informable Aug 16, 2024
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just added some minor comments questoins.

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm requested a review from csviri August 19, 2024 11:36
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great , LGTM!

@metacosm metacosm merged commit 62f8501 into next Aug 19, 2024
20 checks passed
@metacosm metacosm deleted the remove-resourceconfig branch August 19, 2024 13:26
metacosm added a commit that referenced this pull request Aug 29, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
csviri added a commit that referenced this pull request Sep 20, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
metacosm added a commit that referenced this pull request Oct 10, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
metacosm added a commit that referenced this pull request Nov 5, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
metacosm added a commit that referenced this pull request Nov 6, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
csviri added a commit that referenced this pull request Nov 13, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
metacosm added a commit that referenced this pull request Nov 19, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
metacosm added a commit that referenced this pull request Nov 20, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
metacosm added a commit that referenced this pull request Nov 27, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
csviri added a commit that referenced this pull request Dec 6, 2024
---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants