Skip to content

feat: read-only bulk dependent #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2024
Merged

feat: read-only bulk dependent #2372

merged 4 commits into from
May 14, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 30, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@csviri csviri linked an issue Apr 30, 2024 that may be closed by this pull request
Support Bulk read-only dependent resources #2233
Closed
@csviri csviri marked this pull request as ready for review May 2, 2024 14:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2024
@openshift-ci openshift-ci bot requested a review from adam-sandor May 2, 2024 14:40
@csviri
feat: read-only bulkd dependent
856d8b7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@openshift-ci openshift-ci bot requested a review from andreaTP May 2, 2024 14:40
csviri added 2 commits May 2, 2024 16:40
@csviri
obsolete line
41bb90e 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
Sample
b8cf132 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri force-pushed the bulk-read-only branch from 50bf182 to b8cf132 Compare May 2, 2024 14:40
@csviri csviri requested a review from metacosm May 2, 2024 14:44
csviri
csviri commented May 2, 2024
View reviewed changes
...n/java/io/javaoperatorsdk/operator/processing/dependent/BulkDependentResourceReconciler.java Outdated
.toList());
}

final var desiredResources = bulkDependentResource.desiredResources(primary, context);

// remove existing resources that are not needed anymore according to the primary state
deleteExtraResources(desiredResources.keySet(), actualResources, primary, context);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH this is interesting we should probably check if we are deleter? But what if not ? :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand…

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it, before deleting extra resources was called all the time now we check if this DR is a deleter.

@csviri
deleter check
3483d03 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri merged commit 6d7b71c into next May 14, 2024
20 checks passed
@csviri csviri deleted the bulk-read-only branch May 14, 2024 12:49
csviri added a commit that referenced this pull request May 17, 2024
@csviri
feat: read-only bulk dependent (#2372)
16c3c03 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri
feat: read-only bulk dependent (#2372)
da82ec0 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 21, 2024
@csviri
feat: read-only bulk dependent (#2372)
fa2f06a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jun 17, 2024
@csviri
feat: read-only bulk dependent (#2372)
35da297 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 8, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
8dc9c8d 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 9, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
5b9b1f4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 12, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
04f7952 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Aug 8, 2024
@csviri
feat: read-only bulk dependent (#2372)
eb7becd 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Aug 14, 2024
Merged
csviri added a commit that referenced this pull request Aug 15, 2024
@csviri
feat: read-only bulk dependent (#2372)
fbc2601 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Aug 29, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
52efcad 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Sep 17, 2024
Merged
csviri added a commit that referenced this pull request Sep 20, 2024
@csviri
feat: read-only bulk dependent (#2372)
1044018 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Oct 10, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
c85aa73 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 5, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
8038386 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 6, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
c5f8062 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Nov 13, 2024
@csviri
feat: read-only bulk dependent (#2372)
d506116 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 19, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
3feb45a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 20, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
85389b7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 27, 2024
@csviri @metacosm
feat: read-only bulk dependent (#2372)
007938d 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
This was referenced Dec 3, 2024
Merged
Closed
csviri added a commit that referenced this pull request Dec 6, 2024
@csviri
feat: read-only bulk dependent (#2372)
0b8d8dd 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Bulk read-only dependent resources
2 participants
@csviri @metacosm