Skip to content

feat: all event source is resource event source #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 2, 2024
Merged

feat: all event source is resource event source #2367

merged 7 commits into from
May 2, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 29, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2024
@csviri csviri self-assigned this Apr 29, 2024
@csviri
Copy link
Collaborator Author

csviri commented Apr 29, 2024 •
edited
Loading

Some weirdness with this:

  • TimerEvent source is the only one actually not fitting I this model (Simple inbound event source we could delete, but that is something to discuss). With this model, it is hacky to create a non-resource event source. But will be any?

So this needs discussion if we want to proceed this way. But certainly simplifies API-s, although EventSource interface became much more complex, but since we provide event sources out of the box not sure if a big problem.

Certainly easier to reason about in most situations with this approach.

@metacosm

@csviri csviri linked an issue Apr 29, 2024 that may be closed by this pull request
Every EventSource should be a ResourceEventSource #2107
Closed
@csviri csviri requested a review from metacosm April 29, 2024 08:50
@csviri csviri marked this pull request as ready for review April 30, 2024 12:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@openshift-ci openshift-ci bot requested a review from adam-sandor April 30, 2024 12:18
@csviri csviri force-pushed the every-es-resource-es branch from 08f7a7a to d27887e Compare May 2, 2024 06:03
csviri and others added 4 commits May 2, 2024 14:47
@csviri @metacosm
feat: all event source is resource event source
cb64356 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
test fix
09280cf 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm
feat: merge EventSource and EventSourceMetadata
faba864 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
refactor: more accurate name
973da6c 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm force-pushed the every-es-resource-es branch from d27887e to 973da6c Compare May 2, 2024 13:01
metacosm added 2 commits May 2, 2024 18:40
@metacosm
refactor: no need to expose optional configuration
28cca35 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm
docs: add note on EventSourceProvider removal
c8949f3 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
format
aa7e24a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri merged commit fd8c2c9 into next May 2, 2024
20 checks passed
@csviri csviri deleted the every-es-resource-es branch May 2, 2024 17:57
csviri added a commit that referenced this pull request May 17, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
8f3203c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
3cc9398 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 21, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
27ca97c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jun 17, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
ca35dc2 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 8, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
0e76ea3 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 9, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
ca1acec 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Jul 12, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
c5ccd1d 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Aug 8, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
f5723fb 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Aug 14, 2024
Merged
csviri added a commit that referenced this pull request Aug 15, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
5c59a43 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Aug 29, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
8083392 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Sep 17, 2024
Merged
csviri added a commit that referenced this pull request Sep 20, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
0cd5a92 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Oct 10, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
8097564 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 5, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
a0e3d99 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 6, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
c1d72b5 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Nov 13, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
d72a9e7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 19, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
5a62623 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 20, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
42850a0 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm added a commit that referenced this pull request Nov 27, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
76aa452 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
This was referenced Dec 3, 2024
Merged
Closed
csviri added a commit that referenced this pull request Dec 6, 2024
@csviri @metacosm
feat: all event source is resource event source (#2367)
99efc7d 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Every EventSource should be a ResourceEventSource
2 participants
@csviri @metacosm