Skip to content

improve: samples correctly create status object for SSA #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 24, 2024

No description provided.

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri requested a review from metacosm April 24, 2024 12:29
@csviri csviri self-assigned this Apr 24, 2024
@openshift-ci openshift-ci bot requested review from adam-sandor and andreaTP April 24, 2024 12:29
String userName) {
MySQLSchema res = new MySQLSchema();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, having to do that for SSA is quite annoying… I'm wondering if there's anything we can do about it…

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure, maybe an utility to clone a shallow class? this results certainly in a kind of a boilerplate code .

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri merged commit 69ee626 into next Apr 25, 2024
20 checks passed
@csviri csviri deleted the create-fresh-status-update-app branch April 25, 2024 17:58
csviri added a commit that referenced this pull request May 17, 2024

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 17, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 21, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jun 17, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 8, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 9, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 12, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Aug 8, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Aug 15, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Aug 29, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Sep 20, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Oct 10, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 5, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 6, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Nov 13, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 19, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 20, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Nov 27, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Dec 6, 2024
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants