fix: allow to burst threads by default #2262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
The current approach used a non-bound queue, therefore the thread were not added dynamically into the Threadpool Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
executor-service-config
branch
from
032f39c to
856a00a
Compare
csviri
changed the title
SynchronousQueue
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
This approach will lead to better startup performance. The ExecutorService can be replaced and fine-tuned. IMO the best approach would be to have a pooled executor that increases the size as now to an upper bound on demand and then queues the remaining elements, which would cover the initial burst on startup nicely. |
|
This could be a change for v5, we don't need to necessarily release it as a bugfix. |
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
changed the title
|
replaced by: #2265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach used a non-bound queue, therefore the thread were not added dynamically into the Threadpool.
As described in the docs of https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadPoolExecutor.html
If the queue is not bounded, it will just accumulate the submitted tasks.