-
Notifications
You must be signed in to change notification settings - Fork 219
refactor: add default implementation for name() #2255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
05c84a9
39d0ff1
a9929af
1b906cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,6 +54,9 @@ public Optional<Condition<R, P>> getReconcilePrecondition() { | |
return Optional.ofNullable(reconcilePrecondition); | ||
} | ||
|
||
public String getName() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not very good practice in my opinion, it kinda implies that it's the name of the dependent node not the dependent resource. I would either remove this, and always access the name though DependentResource or rename this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pls do, when started looking it was kinda confusing now, what now we are talking about There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is really small thing, at least for me it is much easier to jump to a conclusion with that pattern :) |
||
return dependentResource.name(); | ||
} | ||
|
||
public Optional<Condition<R, P>> getDeletePostcondition() { | ||
return Optional.ofNullable(deletePostcondition); | ||
|
Uh oh!
There was an error while loading. Please reload this page.