Skip to content

improve: name for dependent node explicitly #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

improve: name for dependent node explicitly #2165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...java/io/javaoperatorsdk/operator/processing/dependent/workflow/DependentResourceNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ public class DependentResourceNode<R, P extends HasMetadata> {
private Condition<R, P> activationCondition;
private final DependentResource<R, P> dependentResource;

DependentResourceNode(String name, DependentResource<R, P> dependentResource) {
this(name, null, null, null, null, dependentResource);
}

DependentResourceNode(DependentResource<R, P> dependentResource) {
this(getNameFor(dependentResource), null, null, null, null, dependentResource);
}
Expand Down
11 changes: 8 additions & 3 deletions .../main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/WorkflowBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,15 @@ public class WorkflowBuilder<P extends HasMetadata> {
private boolean isCleaner = false;

public WorkflowBuilder<P> addDependentResource(DependentResource dependentResource) {
currentNode = new DependentResourceNode<>(dependentResource);
return addDependentResource(dependentResource, null);
}

public WorkflowBuilder<P> addDependentResource(DependentResource dependentResource, String name) {
currentNode = name == null ? new DependentResourceNode<>(dependentResource)
: new DependentResourceNode<>(name, dependentResource);
isCleaner = isCleaner || dependentResource.isDeletable();
final var name = currentNode.getName();
dependentResourceNodes.put(name, currentNode);
final var actualName = currentNode.getName();
dependentResourceNodes.put(actualName, currentNode);
return this;
}

Expand Down