Skip to content

feat: generic kubernetes resource usage #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 13, 2023
Merged

feat: generic kubernetes resource usage #2136

merged 16 commits into from
Dec 13, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Dec 1, 2023

This features makes it possible to use GenericKubernetesResource in plain reconciliations also in dependent resources.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
@csviri csviri linked an issue Dec 1, 2023 that may be closed by this pull request
Support GenericKubernetesResource based Dependent Resources #2126
Closed
@csviri csviri marked this pull request as ready for review December 1, 2023 14:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
@csviri csviri mentioned this pull request Dec 5, 2023
Closed
@csviri csviri force-pushed the generic-kubernetes-dependent branch from 6591e0d to 8a963e9 Compare December 5, 2023 09:36
@csviri
chore: change version to 4.7.0-SNAPSHOT (#2132)
3b04c47 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added 11 commits December 5, 2023 10:38
@csviri
feat: GenericKubernetesResource based DependentResource
9e0e810 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
progess
fee9a7a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
wip
e376fa2 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
IT skeleton
2430233 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
inetgration tests
5f4abf8 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
increase IT timeout
21043b4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
pure resource handling test
0f16ef4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
handling informer for GenericKubernetesDependentResource
7181b01 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fixes
8041c16 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
minor improvement
41c8f9f 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
docs
67c571a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri force-pushed the generic-kubernetes-dependent branch from 8a963e9 to 67c571a Compare December 5, 2023 09:38
@csviri csviri self-assigned this Dec 5, 2023
csviri added 3 commits December 5, 2023 14:21
@csviri
gvk enhancement
dd53037 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
equals & hash for gvk
b6e6f52 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
to string for gvk
f00dd5e 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm
Copy link
Collaborator

Wondering if we should also make generic dependents available via the Context. Otherwise, LGTM.

@csviri
Copy link
Collaborator Author

csviri commented Dec 13, 2023

Wondering if we should also make generic dependents available via the Context. Otherwise, LGTM.

It is available with context.getSecondaryResources(GenericKubernetesResource.class) It might be not ideal, this way, I mean a GVK as param would be nice, (or just that), but using this in a project an it is easy enough to handle this way.

@csviri csviri merged commit 1f9cd4b into next Dec 13, 2023
@csviri csviri deleted the generic-kubernetes-dependent branch December 13, 2023 21:31
csviri added a commit that referenced this pull request Dec 15, 2023
@csviri
feat: generic kubernetes resource usage (#2136)
1d72755 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri mentioned this pull request Jan 4, 2024
Closed
csviri added a commit that referenced this pull request Jan 8, 2024
@csviri
feat: generic kubernetes resource usage (#2136)
a943a8e 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jan 8, 2024
@csviri
feat: generic kubernetes resource usage (#2136)
58bd66c 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jan 10, 2024
@csviri
feat: generic kubernetes resource usage (#2136)
9d576b0 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jan 10, 2024
@csviri
feat: generic kubernetes resource usage (#2136)
7a43868 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GenericKubernetesResource based Dependent Resources
2 participants
@csviri @metacosm