improve: matcher for config maps #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
requested review from
shawkins and
metacosm
and removed request for
shawkins
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm
reviewed
Nov 13, 2023
| } else if (nodeIsChildOf(node, List.of(METADATA))) { | ||
| // conditionally consider labels and annotations | ||
| if (considerMetadata | ||
| && nodeIsChildOf(node, List.of(METADATA_LABELS, METADATA_ANNOTATIONS))) { | ||
| matched = match(labelsAndAnnotationsEquality, node, Collections.emptyList()); | ||
| } | ||
| } else if (!nodeIsChildOf(node, IGNORED_FIELDS)) { | ||
| matched = match(true, node, ignoreList); | ||
| matched = match(valuesEquality, node, ignoreList); |
There was a problem hiding this comment.
So that's the only "real" change, right?
metacosm
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.