Skip to content

feat: using dynamic ThreadPoolExecutor for reconcile and workflow executor services #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 9, 2023

No description provided.

@csviri csviri self-assigned this Mar 9, 2023
@csviri csviri requested a review from metacosm March 9, 2023 15:20
@csviri csviri linked an issue Mar 10, 2023 that may be closed by this pull request
@csviri csviri changed the title feat: using dynamic ThreadPoolExecutor for reconcile and workflow exe… feat: using dynamic ThreadPoolExecutor for reconcile and workflow executor services Mar 10, 2023
default int concurrentWorkflowExecutorThreads() {
return DEFAULT_WORKFLOW_EXECUTOR_THREAD_NUMBER;
}

default int minConcurrentWorkflowExecutorThreads() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add doc for this as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added docs

Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from missing javadoc

@csviri csviri force-pushed the dynamic-thread-pool branch from cd8270f to 97ff33c Compare March 10, 2023 14:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

38.5% 38.5% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit 213cf0f into next Mar 10, 2023
@csviri csviri deleted the dynamic-thread-pool branch March 10, 2023 15:06
csviri added a commit that referenced this pull request Mar 14, 2023
csviri added a commit that referenced this pull request Mar 15, 2023
metacosm pushed a commit that referenced this pull request Mar 22, 2023
metacosm pushed a commit that referenced this pull request Mar 27, 2023
csviri added a commit that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ThreadPoolExecutor with Unlimited Queue but Max Size.
2 participants