fix: remove okhttp dependency #1793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
force-pushed
the
remove-okhttp
branch
2 times, most recently
from
0480f6b to
9918f6f
Compare
csviri
approved these changes
Mar 8, 2023
csviri
reviewed
Mar 8, 2023
operator-framework/pom.xml
Outdated
|
|
||
| <dependency> | ||
| <groupId>io.fabric8</groupId> | ||
| <artifactId>kubernetes-httpclient-jdk</artifactId> |
There was a problem hiding this comment.
Should not be this the vertx client?
There was a problem hiding this comment.
As mentioned previously off-line, I would like to have tests with different clients to see if there is any impact
csviri
reviewed
Mar 8, 2023
| @@ -54,6 +54,11 @@ | |||
| <type>test-jar</type> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.fabric8</groupId> | |||
| <artifactId>kubernetes-httpclient-okhttp</artifactId> | |||
There was a problem hiding this comment.
Why is okhttp in this module? Probably should be vertx
There was a problem hiding this comment.
Let's test with all the different clients in integration tests in a different PR. In this PR, I wanted to have "some" coverage of the different http client implementations without getting into all possible combinations.
csviri
reviewed
Mar 8, 2023
| @@ -38,6 +38,10 @@ | |||
| <groupId>io.javaoperatorsdk</groupId> | |||
| <artifactId>operator-framework</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.fabric8</groupId> | |||
| <artifactId>kubernetes-httpclient-okhttp</artifactId> | |||
There was a problem hiding this comment.
Should not be just okhttp in one of these?
csviri
approved these changes
Mar 10, 2023
Also document how to use a different implementation instead of the okhttp one which is the default one and currently, the one we recommend to use. Vert.X implementation is also coming along nicely. JDK implementation should work if you're using Java 17 and up, and will work with 11 when some bug fixes land in 11.
|
Kudos, SonarCloud Quality Gate passed! |
csviri
pushed a commit
that referenced
this pull request
Mar 14, 2023
Also document how to use a different implementation instead of the okhttp one which is the default one and currently, the one we recommend to use. Vert.X implementation is also coming along nicely. JDK implementation should work if you're using Java 17 and up, and will work with 11 when some bug fixes land in 11.
csviri
pushed a commit
that referenced
this pull request
Mar 15, 2023
Also document how to use a different implementation instead of the okhttp one which is the default one and currently, the one we recommend to use. Vert.X implementation is also coming along nicely. JDK implementation should work if you're using Java 17 and up, and will work with 11 when some bug fixes land in 11.
metacosm
added a commit
that referenced
this pull request
Mar 22, 2023
Also document how to use a different implementation instead of the okhttp one which is the default one and currently, the one we recommend to use. Vert.X implementation is also coming along nicely. JDK implementation should work if you're using Java 17 and up, and will work with 11 when some bug fixes land in 11.
metacosm
added a commit
that referenced
this pull request
Mar 27, 2023
Also document how to use a different implementation instead of the okhttp one which is the default one and currently, the one we recommend to use. Vert.X implementation is also coming along nicely. JDK implementation should work if you're using Java 17 and up, and will work with 11 when some bug fixes land in 11.
csviri
pushed a commit
that referenced
this pull request
Mar 27, 2023
Also document how to use a different implementation instead of the okhttp one which is the default one and currently, the one we recommend to use. Vert.X implementation is also coming along nicely. JDK implementation should work if you're using Java 17 and up, and will work with 11 when some bug fixes land in 11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.