imrpove: replacing confusing UpdateControl method #1762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
force-pushed
the
update-control-patch
branch
from
151d8ef to
0480cae
Compare
metacosm
requested changes
Feb 8, 2023
...r-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/UpdateControl.java
Outdated
Show resolved
Hide resolved
...r-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/UpdateControl.java
Outdated
Show resolved
Hide resolved
...r-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/UpdateControl.java
Outdated
Show resolved
Hide resolved
| T customResource) { | ||
| return new UpdateControl<>(customResource, true, true, true); | ||
| } | ||
|
|
||
| /** | ||
| * Market for removal, because of confusing name. It does not patch the resource just updates it. | ||
| * This method is same as updateResourceAndPatchStatus. |
...r-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/UpdateControl.java
Show resolved
Hide resolved
csviri
force-pushed
the
update-control-patch
branch
from
820af8c to
93e6fa9
Compare
csviri
force-pushed
the
update-control-patch
branch
from
93e6fa9 to
dda3a10
Compare
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Feb 8, 2023
csviri
added a commit
that referenced
this pull request
Feb 14, 2023
csviri
added a commit
that referenced
this pull request
Feb 23, 2023
csviri
added a commit
that referenced
this pull request
Feb 28, 2023
csviri
added a commit
that referenced
this pull request
Mar 3, 2023
csviri
added a commit
that referenced
this pull request
Mar 10, 2023
csviri
added a commit
that referenced
this pull request
Mar 14, 2023
csviri
added a commit
that referenced
this pull request
Mar 15, 2023
metacosm
pushed a commit
that referenced
this pull request
Mar 22, 2023
metacosm
pushed a commit
that referenced
this pull request
Mar 27, 2023
csviri
added a commit
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.