Generate a Versions file to be consumed at runtime #1667
Conversation
|
Note that this should probably be integrated with https://github.com/java-operator-sdk/java-operator-sdk/blob/main/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Version.java, which already provides the SDK version. |
What I meant is that all these versions should be accessible via |
|
@metacosm I have attempted to follow your comment, unsure if this is what you meant ... |
|
|
||
| private Versions() {} | ||
|
|
||
| protected static final String JOSDK = "${project.version}"; |
There was a problem hiding this comment.
Could you pls enlighten me how this supposed to work? Where are those placeholders filled?
There was a problem hiding this comment.
This file is filled by the Maven Plugin as it is in java-templates folder as opposed to java.
There was a problem hiding this comment.
would it be possible to write a unit test for this?
There was a problem hiding this comment.
Done here: 52643d3
| @@ -47,6 +47,19 @@ | |||
| <commitIdGenerationMode>full</commitIdGenerationMode> | |||
| </configuration> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>org.codehaus.mojo</groupId> | |||
There was a problem hiding this comment.
To fill in the information that is available in Maven.
|
@andreaTP could you give me access to push changes to your branch, please? Or would you prefer I open a different PR based on this one with my changes? |
|
@metacosm as you prefer, you have an invite for my fork or you can open another PR to target the improvements or whatever. |
|
Didn't easily manage to push changes to the original branch so created a new PR: #1706. |
|
No worries, thanks @metacosm ! |
This will enable compile time checks of the versions in the Quarkus Operator SDK.
ref: quarkiverse/quarkus-operator-sdk#460
cc. @metacosm