Skip to content

fix: leader election stop deadlock #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 24, 2022
Merged

fix: leader election stop deadlock #1618

merged 8 commits into from
Nov 24, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Nov 22, 2022

alternative to:
#1615

This might be a better solution since, will stop the leader elector if somebody explicitly calls stop

@csviri csviri self-assigned this Nov 22, 2022
@csviri csviri requested a review from metacosm November 22, 2022 12:53
@csviri csviri force-pushed the leader-stop-bug-alternative branch from ad0f91c to c0d3e15 Compare November 23, 2022 12:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit e067f65 into main Nov 24, 2022
@csviri csviri deleted the leader-stop-bug-alternative branch November 24, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LeaderElectionManager#stopLeading maybe deadlock with Operator#installShutdownHook
2 participants