fix: default stop handler exists only if informer started #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
reviewed
Oct 27, 2022
| @@ -41,7 +41,7 @@ class InformerRelatedBehaviorITS { | |||
| KubernetesClient adminClient = new KubernetesClientBuilder().build(); | |||
| InformerRelatedBehaviorTestReconciler reconciler; | |||
| String actualNamespace; | |||
| volatile boolean stopHandlerCalled = false; | |||
| volatile boolean stopHandlerCalledReplacement = false; | |||
There was a problem hiding this comment.
well, there is a default one originally
There was a problem hiding this comment.
Suggested change
| volatile boolean stopHandlerCalledReplacement = false; | |
| volatile boolean replacementStopHandlerCalled = false; |
would be more correct, imo, then.
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Oct 27, 2022
csviri
added a commit
that referenced
this pull request
Oct 28, 2022
csviri
added a commit
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.